martinzink commented on code in PR #2061:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2061#discussion_r2588423779


##########
extensions/standard-processors/tests/features/evaluate_json_path.feature:
##########
@@ -39,12 +40,16 @@ Feature: Writing JSON path query result to attribute or 
flow file using Evaluate
     And the "author" property of the EvaluateJsonPath processor is set to 
"$.author"
     And the "release" property of the EvaluateJsonPath processor is set to 
"$.release"
     And a PutFile processor with the "Directory" property set to "/tmp/output"
+    And PutFile is EVENT_DRIVEN
     And a LogAttribute processor
+    And LogAttribute is EVENT_DRIVEN
     And the "success" relationship of the GetFile processor is connected to 
the EvaluateJsonPath
     And the "matched" relationship of the EvaluateJsonPath processor is 
connected to the PutFile
     And the "success" relationship of the PutFile processor is connected to 
the LogAttribute
+    And PutFile's failure relationship is auto-terminated
+    And LogAttribute's success relationship is auto-terminated
     When the MiNiFi instance starts up
-    Then a flowfile with the JSON content "{"title": "1984", "author": null}" 
is placed in the monitored directory in less than 10 seconds
+    Then a file with the JSON content "{"title": "1984", "author": null}" is 
placed in the "/tmp/output" directory in less than 10 seconds
     And the Minifi logs contain the following message: "key:title value:1984" 
in less than 10 seconds
-    And the Minifi logs contain the following message: "key:author value:null" 
in less than 0 seconds
-    And the Minifi logs do not contain the following message: "key:release" 
after 0 seconds
+    And the Minifi logs contain the following message: "key:author value:null" 
in less than 1 seconds
+    And the Minifi logs do not contain the following message: "key:release" 
after 10 seconds

Review Comment:
   I can only speak for myself, but I've encountered a bug in the framework 
where if yhe timeout is too low it wont even check it once, that should be 
fixed then I think these can be reverted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to