exceptionfactory commented on code in PR #10601: URL: https://github.com/apache/nifi/pull/10601#discussion_r2589853192
########## nifi-extension-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/java/org/apache/nifi/processors/asana/GetAsanaObject.java: ########## @@ -83,6 +84,7 @@ import static org.apache.nifi.processors.asana.AsanaObjectType.AV_COLLECT_TASK_ATTACHMENTS; import static org.apache.nifi.processors.asana.AsanaObjectType.AV_COLLECT_TEAM_MEMBERS; +@DeprecationNotice(reason = "Depends on unsupported java-asana library") Review Comment: Thanks @dan-s1. That sounds like something to consider at the UI or framework level. Other components with the `DeprecationNotice` annotation do not include the `deprecated`, and it seems like an anti-pattern given the name of the annotation. The description in NIFI-14845 looks like a good summary of some ways forward. ########## nifi-extension-bundles/nifi-asana-bundle/nifi-asana-processors/src/main/java/org/apache/nifi/processors/asana/GetAsanaObject.java: ########## @@ -83,6 +84,7 @@ import static org.apache.nifi.processors.asana.AsanaObjectType.AV_COLLECT_TASK_ATTACHMENTS; import static org.apache.nifi.processors.asana.AsanaObjectType.AV_COLLECT_TEAM_MEMBERS; +@DeprecationNotice(reason = "Depends on unsupported java-asana library") Review Comment: Thanks @dan-s1. That sounds like something to consider at the UI or framework level. Other components with the `DeprecationNotice` annotation do not include the word `deprecated`, and it seems like an anti-pattern given the name of the annotation. The description in NIFI-14845 looks like a good summary of some ways forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
