exceptionfactory opened a new pull request, #10603: URL: https://github.com/apache/nifi/pull/10603
# Summary [NIFI-15296](https://issues.apache.org/jira/browse/NIFI-15296) Corrects framework enabling of referenced Controller Services with unsatisfied property dependencies. The primary change in `StandardControllerServiceNode.getRequriedControllerServices()` now evaluates whether a configured and referenced Controller Service has property dependencies satisfied. Referenced Controller Services that do not depend on other property values remain included in the list of required Controller Services. Referenced Controller Services that depend on other property values, and have those dependencies satisfied also remain included. The method now filters out Controller Services that do not have satisfied dependencies, which avoids enabling unnecessary Controller Services as part of the chain of enabling the parent Controller Service. The initial implementation of `getRequiredControllerServices()` predated the introduction of dependent properties. The need to avoid enabling selected Controller Services is limited to the situation where a Controller Service property depends on the value of another property. A new unit test method exercises the updated behavior, with a `PrimaryService` that has two properties. The `PrimaryService` has a required property that references a `Secondary Service` and also has a required property named `Secondary Service Enabled` on which the `Secondary Service` property depends. The unit sets configures a Controller Service Identifier for the `Secondary Service` but verifies that the service is not enabled, because the `Secondary Service Enabled` property is not configured. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `./mvnw clean install -P contrib-check` - [X] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
