pvillard31 opened a new pull request, #10616:
URL: https://github.com/apache/nifi/pull/10616
# Summary
NIFI-14233 - Fix Python Processor imported property dependencies
Fixes NIFI-14233 where Python Processors could not use imported
`PropertyDescriptors` as `PropertyDependencies`. This regression was introduced
in NIFI-13872 and prevented processors from using a common pattern of sharing
property definitions across multiple processors via imports.
When a `PropertyDescriptor` was imported from another module and used in a
`PropertyDependency`, NiFi failed to load the processor with a `KeyError`:
```python
from SharedModule import SHARED_PROPERTY
from nifiapi.properties import PropertyDescriptor, PropertyDependency
class MyProcessor:
MY_PROPERTY = PropertyDescriptor(
name="My Property",
dependencies=[PropertyDependency(SHARED_PROPERTY, "value")] #
Failed with KeyError
)
```
The AST-based `ProcessorInspection` only discovered PropertyDescriptors
defined within the current class, not imported ones.
- Added functions to parse import statements and resolve PropertyDescriptors
from imported modules
- Modified `CollectPropertyDescriptorVisitors` to accept and check imported
descriptors when resolving dependencies
- Changed direct dictionary access `[]` to `.get()` to handle missing
properties gracefully
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue
created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as
`NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number,
as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing
changes
# Verification
Please indicate the verification steps performed prior to pull request
creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License
Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE`
files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
