szaszm commented on code in PR #2079:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2079#discussion_r2598673519
##########
CONFIGURE.md:
##########
@@ -454,19 +454,25 @@ If a processor is triggered but has no work available, it
will yield for the con
# in minifi.properties
nifi.bored.yield.duration=100 millis
-### Graceful shutdown period
+### FlowController drain timeout and graceful shutdown period
-It is possible to configure a graceful shutdown period, the period the flow
controller will wait to unload the flow configuration and stop running
processors.
+When the flow is stopped, either because of a flow update from C2, a stop or
restart command from C2, or because MiNiFi is stopped by the operating system,
+MiNiFi stops all source processors (processors without incoming connections)
first. Next, it waits for all connection queues to become empty, but
+at most the amount of time set in the
# in minifi.properties
- nifi.flowcontroller.graceful.shutdown.period=30 sec
+ nifi.flowcontroller.drain.timeout=5 sec
-### FlowController drain timeout
+property. The default value is zero, i.e., no wait. Finally, it shuts down the
remaining processors. If there are flow files left in some connection
+queues after the drain timeout, they will be discarded.
Review Comment:
This is not quite correct if I understand it right. I'd clarify to avoid
giving users a heart attack by making them think they lose data. :sweat_smile:
```suggestion
queues after the drain timeout, they will remain saved to disk (when using
persistent repositories, which is the default) or be discarded (when using
volatile repositories).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
