exceptionfactory opened a new pull request, #10675: URL: https://github.com/apache/nifi/pull/10675
# Summary [NIFI-15341](https://issues.apache.org/jira/browse/NIFI-15341) Corrects resolution of External Controller Service references for migrated properties. The existing implementation of the Controller Service Resolver performs several checks to find a matching Controller Service implementation, including a lookup of the Controller Service API for each referenced Property Descriptor. The current approach attempts to find the Controller Service API based on the property name from the Versioned Processor or Controller Service, which results in a lookup failure when the property name has been changed and migrated. The revised approach uses the Controller Service identifier from the property value to find the Name of the External Controller Service, and then searches available Controller Services to find matching values. This approach avoids the problem with potential migration of property names and ensures that the expected Name-based lookup for an External Controller Service works as expected. Changes include a new unit test method the exercises the expected behavior, with a Controller Service definition having a property named `ssl-context-service`, and referencing and External Controller Service named `Provided SSL Context Service`. The included flow definition from NiFi 2.0.0 can also be used to test at runtime using a Controller Service named `Provided SSL Context Service` in a parent Process Group. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `./mvnw clean install -P contrib-check` - [X] JDK 21 - [X] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
