mcgilman commented on code in PR #42:
URL: https://github.com/apache/nifi-api/pull/42#discussion_r2665574755
##########
src/main/java/org/apache/nifi/components/connector/Connector.java:
##########
@@ -195,4 +196,12 @@ public interface Connector {
List<AllowableValue> fetchAllowableValues(String stepName, String
propertyName, FlowContext flowContext);
List<AllowableValue> fetchAllowableValues(String stepName, String
propertyName, FlowContext flowContext, String filter);
+
+ /**
+ * Drains any in-flight FlowFiles from the flow associated with the given
Flow Context by processing the existing data
+ * but not accepting any new data.
+ * @param flowContext the flow context
+ * @return a Future that will be completed when the draining is complete
+ */
+ CompletableFuture<Void> drainFlowFiles(FlowContext flowContext);
Review Comment:
This changes causes an issue with `AbstractConnector`.
> 'drainFlowFiles(FlowContext)' in
'org.apache.nifi.components.connector.AbstractConnector' clashes with
'drainFlowFiles(FlowContext)' in
'org.apache.nifi.components.connector.Connector'; attempting to assign weaker
access privileges ('protected'); was 'public'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
