martinzink commented on code in PR #2083:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2083#discussion_r2672326462
##########
libminifi/src/core/RepositoryFactory.cpp:
##########
@@ -44,6 +47,10 @@ std::unique_ptr<core::ContentRepository>
createContentRepository(const std::stri
return
std::make_unique<core::repository::FileSystemRepository>(repo_name);
}
if (fail_safe) {
Review Comment:
im usually on the side to fail fast and fail hard :D so we might just remove
this fail_safe parameter and crash in that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
