exceptionfactory commented on code in PR #10745:
URL: https://github.com/apache/nifi/pull/10745#discussion_r2673506421
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteStreamCommand.java:
##########
@@ -575,10 +576,9 @@ public void testSmallEchoPutToAttributeDynamicProperties()
{
assertEquals(isWindows() ? "cmd.exe" : "echo",
outputFlowFile.getAttribute("execution.command"));
}
- @DisabledOnOs(value = OS.WINDOWS, disabledReason = "Not reaching expected
relationships")
@Test
public void testArgumentsWithQuotesFromAttributeDynamicProperties() throws
Exception {
- File dummy = new File("src/test/resources/TestJson/json-sample.json");
+ File dummy = new
File("src/test/resources/TestJson/inline-json-sample.json");
Review Comment:
Rather than create a new JSON file, I recommend simplifying the test with a
basic string that avoids the JSON comparison entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
