pvillard31 commented on code in PR #10716:
URL: https://github.com/apache/nifi/pull/10716#discussion_r2676859492
##########
nifi-extension-bundles/nifi-box-bundle/nifi-box-services/src/main/java/org/apache/nifi/box/controllerservices/JsonConfigBasedBoxClientService.java:
##########
@@ -257,5 +233,8 @@ public void migrateProperties(PropertyConfiguration config)
{
config.renameProperty("app-config-file", APP_CONFIG_FILE.getName());
config.renameProperty("app-config-json", APP_CONFIG_JSON.getName());
ProxyServiceMigration.renameProxyConfigurationServiceProperty(config);
+ // Remove timeout properties that are no longer supported in Box SDK
10.x
+ config.removeProperty("Connect Timeout");
+ config.removeProperty("Read Timeout");
Review Comment:
Regarding the use of the NiFi web client, I'd consider this as a follow up
improvement. I think this does make sense but I don't think this should be part
of this initial effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
