exceptionfactory commented on code in PR #49:
URL: https://github.com/apache/nifi-api/pull/49#discussion_r2699887207
##########
src/main/java/org/apache/nifi/processor/ProcessSession.java:
##########
@@ -253,6 +253,17 @@ default void commitAsync(Runnable onSuccess) {
*/
void adjustCounter(String name, long delta, boolean immediate);
+ /**
+ * Record measurement value for the named Gauge, registering the named
Gauge when not present in the system.
+ *
+ * @param name Gauge name to update or register
+ * @param value Measurement value to record
+ * @param commitTiming Timing for when the measurement value should be
committed
+ */
+ default void recordGauge(String name, double value, CommitTiming
commitTiming) {
Review Comment:
I considered that possibility, but I could also see an argument for making
`NOW` the default option. In the end, I think it is best to follow the pattern
of `adjustCounter`, and require the argument in all cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
