exceptionfactory commented on code in PR #10688: URL: https://github.com/apache/nifi/pull/10688#discussion_r2713678310
########## nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/components/validation/StandardVerifiableComponentFactory.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.components.validation; + +import org.apache.nifi.controller.ControllerService; +import org.apache.nifi.controller.ControllerServiceInitializationContext; +import org.apache.nifi.controller.FlowController; +import org.apache.nifi.controller.ProcessorNode; +import org.apache.nifi.controller.VerifiableControllerService; +import org.apache.nifi.controller.exception.ControllerServiceInstantiationException; +import org.apache.nifi.controller.exception.ProcessorInstantiationException; +import org.apache.nifi.controller.service.ControllerServiceNode; +import org.apache.nifi.controller.service.StandardControllerServiceInitializationContext; +import org.apache.nifi.processor.Processor; +import org.apache.nifi.processor.ProcessorInitializationContext; +import org.apache.nifi.processor.StandardProcessorInitializationContext; +import org.apache.nifi.processor.VerifiableProcessor; +import org.apache.nifi.util.NiFiProperties; + +public class StandardVerifiableComponentFactory implements VerifiableComponentFactory { + + private final FlowController flowController; + private final NiFiProperties nifiProperties; + public StandardVerifiableComponentFactory(final FlowController flowController, final NiFiProperties nifiProperties) { + this.flowController = flowController; + this.nifiProperties = nifiProperties; + } + + @Override + public VerifiableProcessor createProcessor(final ProcessorNode processorNode, final ClassLoader classLoader) throws ProcessorInstantiationException { + final VerifiableProcessor verifiableProcessor; + final String identifier = processorNode.getIdentifier(); + try { + final Class<?> rawProcessorClass = Class.forName(processorNode.getProcessor().getClass().getName(), true, classLoader); + final Class<? extends VerifiableProcessor> processorClass = rawProcessorClass.asSubclass(VerifiableProcessor.class); + verifiableProcessor = processorClass.getDeclaredConstructor().newInstance(); + + final ProcessorInitializationContext tempInitializationContext = new StandardProcessorInitializationContext(identifier, processorNode.getLogger(), + flowController.getControllerServiceProvider(), flowController, flowController.createKerberosConfig(nifiProperties)); + if (verifiableProcessor instanceof Processor processor) { + processor.initialize(tempInitializationContext); + } + } catch (Exception e) { + throw new ProcessorInstantiationException("Could not instantiate Processor", e); Review Comment: The class name should be included for troubleshooting: ```suggestion throw new ProcessorInstantiationException("Failed to instantiate Verifiable Processor Class [%s]".formatted(processorClass), e); ``` ########## nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/components/validation/StandardVerifiableComponentFactory.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.components.validation; + +import org.apache.nifi.controller.ControllerService; +import org.apache.nifi.controller.ControllerServiceInitializationContext; +import org.apache.nifi.controller.FlowController; +import org.apache.nifi.controller.ProcessorNode; +import org.apache.nifi.controller.VerifiableControllerService; +import org.apache.nifi.controller.exception.ControllerServiceInstantiationException; +import org.apache.nifi.controller.exception.ProcessorInstantiationException; +import org.apache.nifi.controller.service.ControllerServiceNode; +import org.apache.nifi.controller.service.StandardControllerServiceInitializationContext; +import org.apache.nifi.processor.Processor; +import org.apache.nifi.processor.ProcessorInitializationContext; +import org.apache.nifi.processor.StandardProcessorInitializationContext; +import org.apache.nifi.processor.VerifiableProcessor; +import org.apache.nifi.util.NiFiProperties; + +public class StandardVerifiableComponentFactory implements VerifiableComponentFactory { + + private final FlowController flowController; + private final NiFiProperties nifiProperties; + public StandardVerifiableComponentFactory(final FlowController flowController, final NiFiProperties nifiProperties) { + this.flowController = flowController; + this.nifiProperties = nifiProperties; + } + + @Override + public VerifiableProcessor createProcessor(final ProcessorNode processorNode, final ClassLoader classLoader) throws ProcessorInstantiationException { + final VerifiableProcessor verifiableProcessor; + final String identifier = processorNode.getIdentifier(); + try { + final Class<?> rawProcessorClass = Class.forName(processorNode.getProcessor().getClass().getName(), true, classLoader); + final Class<? extends VerifiableProcessor> processorClass = rawProcessorClass.asSubclass(VerifiableProcessor.class); + verifiableProcessor = processorClass.getDeclaredConstructor().newInstance(); + + final ProcessorInitializationContext tempInitializationContext = new StandardProcessorInitializationContext(identifier, processorNode.getLogger(), + flowController.getControllerServiceProvider(), flowController, flowController.createKerberosConfig(nifiProperties)); + if (verifiableProcessor instanceof Processor processor) { + processor.initialize(tempInitializationContext); + } + } catch (Exception e) { + throw new ProcessorInstantiationException("Could not instantiate Processor", e); + } + return verifiableProcessor; + } + + @Override + public VerifiableControllerService createControllerService(final ControllerServiceNode serviceNode, final ClassLoader classLoader) { + final VerifiableControllerService verifiableControllerService; + final String identifier = serviceNode.getIdentifier(); + try { + final Class<?> rawControllorServiceClass = Class.forName(serviceNode.getCanonicalClassName(), true, classLoader); + final Class<? extends VerifiableControllerService> controllerServiceClass = rawControllorServiceClass.asSubclass(VerifiableControllerService.class); + verifiableControllerService = controllerServiceClass.getDeclaredConstructor().newInstance(); + + final ControllerServiceInitializationContext tempInitializationContext = new StandardControllerServiceInitializationContext(identifier, + serviceNode.getLogger(), + flowController.getControllerServiceProvider(), flowController.getStateManagerProvider().getStateManager(identifier), + flowController.createKerberosConfig(nifiProperties), flowController); + if (verifiableControllerService instanceof ControllerService controllerService) { + controllerService.initialize(tempInitializationContext); + } + } catch (Exception e) { + throw new ControllerServiceInstantiationException("Could not instantiate Controller Service", e); Review Comment: Some comments as above regarding class name reference for troubleshooting. ########## nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceNode.java: ########## @@ -919,4 +932,8 @@ private long getDelay(final AtomicLong trackedDelay, final long incrementalDelay return selectedDelay; } + + public VerifiableComponentFactory getVerifiableComponentFactory() { Review Comment: Is this public get method needed? ########## nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/components/validation/StandardVerifiableComponentFactory.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.components.validation; + +import org.apache.nifi.controller.ControllerService; +import org.apache.nifi.controller.ControllerServiceInitializationContext; +import org.apache.nifi.controller.FlowController; +import org.apache.nifi.controller.ProcessorNode; +import org.apache.nifi.controller.VerifiableControllerService; +import org.apache.nifi.controller.exception.ControllerServiceInstantiationException; +import org.apache.nifi.controller.exception.ProcessorInstantiationException; +import org.apache.nifi.controller.service.ControllerServiceNode; +import org.apache.nifi.controller.service.StandardControllerServiceInitializationContext; +import org.apache.nifi.processor.Processor; +import org.apache.nifi.processor.ProcessorInitializationContext; +import org.apache.nifi.processor.StandardProcessorInitializationContext; +import org.apache.nifi.processor.VerifiableProcessor; +import org.apache.nifi.util.NiFiProperties; + +public class StandardVerifiableComponentFactory implements VerifiableComponentFactory { + + private final FlowController flowController; + private final NiFiProperties nifiProperties; + public StandardVerifiableComponentFactory(final FlowController flowController, final NiFiProperties nifiProperties) { + this.flowController = flowController; + this.nifiProperties = nifiProperties; + } + + @Override + public VerifiableProcessor createProcessor(final ProcessorNode processorNode, final ClassLoader classLoader) throws ProcessorInstantiationException { + final VerifiableProcessor verifiableProcessor; + final String identifier = processorNode.getIdentifier(); + try { + final Class<?> rawProcessorClass = Class.forName(processorNode.getProcessor().getClass().getName(), true, classLoader); Review Comment: Recommend declaring `processorClassName` outside of the try-catch block so that it can be used in the exception message. ########## nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardReloadComponent.java: ########## @@ -119,7 +119,6 @@ public void reload(final ProcessorNode existingNode, final String newType, final flowController.getValidationTrigger().trigger(existingNode); } - Review Comment: This line change can be reverted ########## nifi-stateless/nifi-stateless-bundle/nifi-stateless-engine/src/main/java/org/apache/nifi/stateless/engine/StatelessVerifiableComponentFactory.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.stateless.engine; + +import org.apache.nifi.components.state.StateManagerProvider; +import org.apache.nifi.components.validation.VerifiableComponentFactory; +import org.apache.nifi.controller.ControllerService; +import org.apache.nifi.controller.ControllerServiceInitializationContext; +import org.apache.nifi.controller.ProcessorNode; +import org.apache.nifi.controller.VerifiableControllerService; +import org.apache.nifi.controller.exception.ControllerServiceInstantiationException; +import org.apache.nifi.controller.exception.ProcessorInstantiationException; +import org.apache.nifi.controller.kerberos.KerberosConfig; +import org.apache.nifi.controller.service.ControllerServiceNode; +import org.apache.nifi.controller.service.ControllerServiceProvider; +import org.apache.nifi.controller.service.StandardControllerServiceInitializationContext; +import org.apache.nifi.processor.Processor; +import org.apache.nifi.processor.ProcessorInitializationContext; +import org.apache.nifi.processor.StandardProcessorInitializationContext; +import org.apache.nifi.processor.VerifiableProcessor; + +public class StatelessVerifiableComponentFactory implements VerifiableComponentFactory { + + private final StateManagerProvider stateManagerProvider; + private final ControllerServiceProvider controllerServiceProvider; + private final KerberosConfig kerberosConfig; + + public StatelessVerifiableComponentFactory(final StateManagerProvider stateManagerProvider, final ControllerServiceProvider controllerServiceProvider, final KerberosConfig kerberosConfig) { + this.stateManagerProvider = stateManagerProvider; + this.controllerServiceProvider = controllerServiceProvider; + this.kerberosConfig = kerberosConfig; + } + + @Override + public VerifiableProcessor createProcessor(final ProcessorNode processorNode, final ClassLoader classLoader) throws ProcessorInstantiationException { + final VerifiableProcessor verifiableProcessor; + final String identifier = processorNode.getIdentifier(); + try { + final Class<?> rawProcessorClass = Class.forName(processorNode.getProcessor().getClass().getName(), true, classLoader); + final Class<? extends VerifiableProcessor> processorClass = rawProcessorClass.asSubclass(VerifiableProcessor.class); + verifiableProcessor = processorClass.getDeclaredConstructor().newInstance(); + + final ProcessorInitializationContext tempInitializationContext = new StandardProcessorInitializationContext(identifier, processorNode.getLogger(), + controllerServiceProvider, new StatelessNodeTypeProvider(), kerberosConfig); + if (verifiableProcessor instanceof Processor processor) { + processor.initialize(tempInitializationContext); + } + } catch (Exception e) { + throw new ProcessorInstantiationException("Could not instantiate Processor", e); Review Comment: Same comments in these methods as in the standard implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
