adamdebreceni commented on code in PR #2088:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2088#discussion_r2732342213
##########
core-framework/include/http/HTTPClient.h:
##########
@@ -226,16 +230,17 @@ class HTTPClient : public BaseHTTPClient, public
core::ConnectableImpl {
void configure_secure_connection();
- std::chrono::milliseconds getAbsoluteTimeout() const { return
3*read_timeout_; }
+ std::chrono::milliseconds getAbsoluteTimeout() const { return
absolute_timeout_.value_or(3*read_timeout_); }
Review Comment:
removed this getter, I kept the empty optional to mean the 3*read_timeout_,
but for the asset download it is set to 0 by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
