sfc-gh-rpaulin commented on code in PR #10812:
URL: https://github.com/apache/nifi/pull/10812#discussion_r2732996859
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/scheduling/StandardProcessScheduler.java:
##########
@@ -441,6 +441,12 @@ public void onTaskComplete() {
};
LOG.info("Starting {}", procNode);
+
+ if (procNode.isReloadAdditionalResourcesNecessary()) {
Review Comment:
I agree we do not need to. I added the check because I wanted to avoid
switching the thread classloader when it is not required. Performance wise
probably very similar. There are only a few processors that use dynamic
classloading so the idea was to skip the logic for the majority that don't need
this functionality to reduce risk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
