exceptionfactory commented on code in PR #10871:
URL: https://github.com/apache/nifi/pull/10871#discussion_r2779817293
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiWebConfigurationContext.java:
##########
@@ -609,11 +606,7 @@ public ComponentDetails updateComponent(final
NiFiWebConfigurationRequestContext
final ComponentAuthorizable authorizable =
lookup.getControllerService(id);
authorizable.getAuthorizable().authorize(authorizer,
RequestAction.WRITE, NiFiUserUtils.getNiFiUser());
- // authorize any referenced service
-
AuthorizeControllerServiceReference.authorizeControllerServiceReferences(properties,
authorizable, authorizer, lookup);
-
- // authorize any parameter references
-
AuthorizeParameterReference.authorizeParameterReferences(properties,
authorizer, authorizable.getParameterContext(), user);
+
AuthorizeComponentReference.authorizeComponentConfiguration(authorizer, lookup,
authorizable, properties, null);
Review Comment:
Good catch, thanks @pvillard31, I pushed an update to include passing the
Parameter Context for evaluation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
