adamdebreceni commented on code in PR #2065:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2065#discussion_r2782536094
##########
minifi-api/include/minifi-cpp/controllers/RecordSetReader.h:
##########
@@ -16,21 +16,23 @@
*/
#pragma once
-#include "minifi-cpp/core/controller/ControllerService.h"
+#include "minifi-cpp/core/controller/ControllerServiceInterface.h"
#include "minifi-cpp/core/ControllerServiceApiDefinition.h"
#include "minifi-cpp/core/Record.h"
#include "utils/Enum.h"
#include "utils/ProcessorConfigUtils.h"
#include "minifi-cpp/io/InputStream.h"
+#include "minifi-cpp/agent/agent_version.h"
namespace org::apache::nifi::minifi::core {
-class RecordSetReader : public virtual controller::ControllerService {
+class RecordSetReader : public virtual controller::ControllerServiceInterface {
public:
static constexpr auto ProvidesApi = core::ControllerServiceApiDefinition{
.artifact = "minifi-system",
.group = "org.apache.nifi.minifi",
.type = "org.apache.nifi.minifi.core.RecordSetReader",
+ .version = "1.0.0"
Review Comment:
changed it to use the minifi version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]