lordgamez commented on code in PR #2104:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2104#discussion_r2798719150
##########
docker/RunBehaveTests.sh:
##########
@@ -192,22 +192,6 @@ fi
echo "${BEHAVE_OPTS[@]}"
-exec \
- behavex "${BEHAVE_OPTS[@]}" \
- "${docker_dir}/../extensions/standard-processors/tests/features" \
- "${docker_dir}/../extensions/aws/tests/features" \
- "${docker_dir}/../extensions/azure/tests/features" \
- "${docker_dir}/../extensions/sql/tests/features" \
- "${docker_dir}/../extensions/llamacpp/tests/features" \
- "${docker_dir}/../extensions/opc/tests/features" \
- "${docker_dir}/../extensions/kafka/tests/features" \
- "${docker_dir}/../extensions/couchbase/tests/features" \
- "${docker_dir}/../extensions/elasticsearch/tests/features" \
- "${docker_dir}/../extensions/splunk/tests/features" \
- "${docker_dir}/../extensions/gcp/tests/features" \
- "${docker_dir}/../extensions/grafana-loki/tests/features" \
- "${docker_dir}/../extensions/lua/tests/features/" \
- "${docker_dir}/../extensions/civetweb/tests/features/" \
- "${docker_dir}/../extensions/mqtt/tests/features/" \
- "${docker_dir}/../extensions/prometheus/tests/features/" \
- "${docker_dir}/../extensions/python/tests/features/"
+mapfile -t FEATURE_FILES < <(find "${docker_dir}/.." -type f -name '*.feature')
Review Comment:
Good catch, fixed in
https://github.com/apache/nifi-minifi-cpp/pull/2104/commits/7f5cb1c7c22454532acb8348d2a4f54be984901a
##########
extensions/aws/tests/features/steps/steps.py:
##########
@@ -50,10 +50,10 @@ def step_impl(context: MinifiTestContext, processor_name:
str):
context.get_or_create_default_minifi_container().flow_definition.add_processor(processor)
-@step('a s3 server is set up in correspondence with the {processor_name}')
-@step('an s3 server is set up in correspondence with the {processor_name}')
-def step_impl(context: MinifiTestContext, processor_name: str):
+@step('an s3 server is set up')
+def step_impl(context: MinifiTestContext):
context.containers["s3-server"] = S3ServerContainer(context)
+ assert context.containers["s3-server"].deploy()
Review Comment:
Updated in
https://github.com/apache/nifi-minifi-cpp/pull/2104/commits/7f5cb1c7c22454532acb8348d2a4f54be984901a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
