sfc-gh-lkucharski commented on PR #10881: URL: https://github.com/apache/nifi/pull/10881#issuecomment-3929941596
> Thanks for working on this addition @lkuchars. > > The general approach of recording lag is useful, but the naming of `millisBehindLatest` is not very intuitive. The PR title indicates `lag`, so something that includes `lag` seems better, and removing `millis`, although perhaps less clear, would make the name less verbose. The main issue is the object of `latest` being unclear. This seems analogous to the `currentLag` feature of Kafka in some ways, so what do you think about calling it `current.lag` instead? Thanks for the review @exceptionfactory! Yep, `current.lag` sounds much better. Changes commited. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
