adamdebreceni commented on code in PR #2065:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2065#discussion_r2905205007
##########
libminifi/src/controllers/NetworkPrioritizerService.cpp:
##########
@@ -177,13 +166,6 @@ void NetworkPrioritizerService::onEnable() {
logger_->log_trace("{} added to list of applied interfaces", ifc);
}
}
- if (const auto is_default = getProperty(DefaultPrioritizer.name) |
utils::andThen(parsing::parseBool)) {
- if (*is_default) {
- if
(io::NetworkPrioritizerFactory::getInstance()->setPrioritizer(sharedFromThis<NetworkPrioritizerService>())
< 0) {
- throw std::runtime_error("Can only have one prioritizer");
- }
- }
- }
Review Comment:
I removed the whole NetworkPrioritizerFactory stuff, as it set the
prioritizer and cleared it but nobody ever used it, we could also remove this
DefaultPrioritizer property but that would possibly break flows (doubtful
anybody ever used this though), if we accept this I can remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
