szaszm commented on code in PR #2110:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2110#discussion_r2905705905


##########
README.md:
##########
@@ -405,12 +405,6 @@ $ make docker-minimal
 #### Executing integration tests with your docker image
 You can execute system integration tests using a minifi docker image.</br>
 Currently, there are two types of docker integration tests:
-##### Monolith legacy tests (features locates in 
docker/test/integration/features)
-(we are in the process of migrating these)
-  ```
-  ~/Development/code/apache/nifi-minifi-cpp/build
-  $ make docker-verify
-  ```

Review Comment:
   In addition to removing this from the readme, some wording changes would be 
nice to the modular tests. The modular adjective is now redundant, they are now 
just _the_ "docker integration tests". Also there are no longer two types of 
docker integration tests.
   Could you take a look at the rendered result and read the area as a whole 
after the change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to