[ 
https://issues.apache.org/jira/browse/NIFI-15678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064618#comment-18064618
 ] 

ASF subversion and git services commented on NIFI-15678:
--------------------------------------------------------

Commit 40c9a4a63fb58901844ba5096569abf903f37e18 in nifi's branch 
refs/heads/NIFI-15258 from Kevin Doran
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=40c9a4a63fb ]

NIFI-15678 Removed PMD Rules ExhaustiveSwitchHasDefault and 
ImplicitSwitchFallThrough (#10977)

Signed-off-by: David Handermann <[email protected]>

> Remove PMD rules related to switch statements
> ---------------------------------------------
>
>                 Key: NIFI-15678
>                 URL: https://issues.apache.org/jira/browse/NIFI-15678
>             Project: Apache NiFi
>          Issue Type: Task
>            Reporter: Kevin Doran
>            Assignee: Kevin Doran
>            Priority: Minor
>             Fix For: 2.9.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> We have some rules that are tricky to adhere to such as 
> ExhaustiveSwitchHasDefault because the enums they operate on come from 
> upstream nifi-api repository, which should be decoupled from nifi. If a 
> developer wants to add a default to an exhaustive switch, it is good 
> defensive programming because a bump in dependency for nifi-api could result 
> in a switch statement that was previously exhaustive no longer being 
> exhaustive, and if there is a reasonable default, that is preferable to 
> having to make code changes in nifi in order to build nifi-api RCs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to