pvillard31 commented on code in PR #11085:
URL: https://github.com/apache/nifi/pull/11085#discussion_r3018693171
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowUpdateResource.java:
##########
@@ -398,6 +398,11 @@ private void updateFlow(final String groupId, final
ComponentLifecycle component
} else {
final FlowSnapshotContainer originalFlowSnapshotContainer =
serviceFacade.getVersionedFlowSnapshot(vciEntity.getVersionControlInformation(),
true);
originalFlowSnapshot =
originalFlowSnapshotContainer.getFlowSnapshot();
+
+ // Resolve compatible bundles for the rollback snapshot before any
replication occurs,
+ // ensuring that all nodes in the cluster receive the same
resolved bundle versions.
+
serviceFacade.discoverCompatibleBundles(originalFlowSnapshot.getFlowContents());
+
serviceFacade.discoverCompatibleBundles(originalFlowSnapshot.getParameterProviders());
Review Comment:
The forward path also calls `resolveInheritedControllerServices` and
`resolveParameterProviders` after `discoverCompatibleBundles`. Should we do the
same here for the rollback snapshot? Might be fine as a follow-up though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
