szaszm commented on PR #2154: URL: https://github.com/apache/nifi-minifi-cpp/pull/2154#issuecomment-4179237463
Thank you for your contribution! At first glance, your changes seem to do what they're supposed to: catch C++ exceptions, and translate them to Python exceptions. :+1: I'm not sure what happens if no Python stack frame catches the Python exceptions. In that case, letting the exception continue to unwind the C++ stack frames, and eventually rollback the flow file would probably be a better error handling, than letting it become an unhandled Python exception, whatever behavior that means. I didn't test this yet. We may need to change that later. I'd also like to wait for the feedback of @lordgamez, since he has worked quite a bit on the python processor API, he has more insight into the gotchas with python bindings. I'm expecting him to be able to get to this sometime next week, after easter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
