pvillard31 opened a new pull request, #11100:
URL: https://github.com/apache/nifi/pull/11100
# Summary
NIFI-15791 - Add per-secret TTL cache to ParameterProviderSecretsManager
Adds a TTL-based cache for resolved secret values in
ParameterProviderSecretsManager to avoid redundant calls to
ParameterProvider.fetchParameterValues() on every secret lookup. Each secret is
cached independently by its fully qualified name and expires after a
configurable TTL (default 5 minutes). Caching can be disabled by setting the
TTL to 0 sec.
A follow-up improvement will be done to expose an API to invalidate the
cache in case a user wants to force the refresh on the secrets while
configuring a connector.
#### Changes
- **`SecretsManager`** — Added `invalidateCache()` to support programmatic
cache clearing.
- **`SecretsManagerInitializationContext`** — Added `getProperty(String)` to
receive configuration properties without coupling the API to `NiFiProperties`.
- **`NiFiProperties`** — Added `nifi.secrets.manager.cache.ttl` property key.
- **`StandardSecretsManagerInitializationContext`** — Extended to accept and
expose an immutable properties map, implementing the new `getProperty()` method.
- **`FlowController.createSecretsManager()`** — Reads the cache TTL from
`NiFiProperties` and passes it through the initialization context.
- **`ParameterProviderSecretsManager`** — Core caching implementation:
- Per-secret `ConcurrentHashMap` cache keyed by FQN with individual
timestamps.
- TTL of `0` disables all cache reads and writes, preserving existing
behavior.
- `getSecret()` checks cache before calling the provider; `getSecrets()`
partitions references into cache hits and misses, batch-fetching only the
misses.
- `findProvider()` refactored to accept a pre-fetched provider set to
avoid redundant `getSecretProviders()` calls.
- `invalidateCache()` clears all cached entries.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue
created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as
`NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number,
as such `NIFI-00000`
- [ ] Pull request contains [commits
signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
with a registered key indicating `Verified` status
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing
changes
# Verification
Please indicate the verification steps performed prior to pull request
creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License
Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE`
files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
