adamdebreceni commented on code in PR #2148:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2148#discussion_r3079826674
##########
extensions/libarchive/FocusArchiveEntry.cpp:
##########
@@ -179,14 +179,9 @@ int64_t FocusArchiveEntry::ReadCallback::operator()(const
std::shared_ptr<io::In
break;
}
- if (res < ARCHIVE_OK) {
+ if (res < ARCHIVE_OK) { // TODO(MINIFICPP-2761)
logger_->log_error("FocusArchiveEntry can't read header due to archive
error: {}", archive_error_string(input_archive.get()));
- return nlen;
- }
-
- if (res < ARCHIVE_WARN) {
- logger_->log_warn("FocusArchiveEntry got archive warning while reading
header: {}", archive_error_string(input_archive.get()));
- return nlen;
+ return io::IoResult::zero();
Review Comment:
nlen seems to be updated in this loop or is it always 0 at this point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]