pvillard31 opened a new pull request, #11152:
URL: https://github.com/apache/nifi/pull/11152

   # Summary
   
   NIFI-15849 - Fix Bitbucket Data Center sourceCommitId missing on first 
snapshot save
   
   When a user starts version control on Bitbucket Data Center, NiFi performs 
two back-to-back commits: `registerFlow()` creates the initial file, then 
`registerFlowSnapshot()` updates it with the actual flow content. On the second 
call, `expectedCommitSha` is null because there's no prior "version" from the 
user's perspective -- but the file already exists from the first commit. 
Without `sourceCommitId` in the `PUT` request, Bitbucket Data Center rejects 
the update to the existing file, returning a non-JSON error response that NiFi 
can't parse. The fix falls back to `existingContentSha` (which for Bitbucket is 
also a commit SHA) so that the `sourceCommitId` is always provided when the 
file already exists.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-00000`
   - Pull Request commit message starts with Apache NiFi Jira issue number, as 
such `NIFI-00000`
   - Pull request contains [commits 
signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
 with a registered key indicating `Verified` status
   
   ### Pull Request Formatting
   
   - Pull Request based on current revision of the `main` branch
   - Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `./mvnw clean install -P contrib-check`
     - [ ] JDK 21
     - [ ] JDK 25
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to