rfellows commented on code in PR #11142: URL: https://github.com/apache/nifi/pull/11142#discussion_r3094410441
########## nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/connectors/ui/connector-canvas/header-bar/connector-canvas-header-bar.component.html: ########## @@ -0,0 +1,46 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<div class="h-8 connector-header-bar border-b select-none"> + <div class="flex items-center h-full justify-between"> + <div class="flex items-center h-full"> + <button + class="h-8 w-8 border-r pointer" + data-qa="toggle-graph-controls" + (click)="toggleGraphControls.emit()" + [title]="graphControlsOpen() ? 'Close graph controls' : 'Open graph controls'"> + <i + class="primary-color fa" + [ngClass]="{ + 'fa-chevron-right': !graphControlsOpen(), + 'fa-chevron-left': graphControlsOpen() + }"></i> + </button> + <div class="flex items-center px-5"> + <a class="primary-color cursor-pointer" data-qa="back-to-connectors" (click)="backToConnectors.emit()"> + <i class="fa fa-arrow-left mr-2"></i>Installed connectors Review Comment: To be consistent with nifi conventions, we probably want to make this "Installed Connectors" ########## nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/canvas-header-search/canvas-header-search.component.html: ########## @@ -0,0 +1,230 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one or more + ~ contributor license agreements. See the NOTICE file distributed with + ~ this work for additional information regarding copyright ownership. + ~ The ASF licenses this file to You under the Apache License, Version 2.0 + ~ (the "License"); you may not use this file except in compliance with + ~ the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<div class="h-full flex justify-around search-container border-l" [class.open]="searchInputVisible()"> + <button + class="w-8" + aria-label="Search canvas" + [attr.aria-expanded]="searchInputVisible()" + (click)="toggleSearchVisibility()"> + <i class="fa fa-search primary-color"></i> + </button> + <ng-template + cdkConnectedOverlay + [cdkConnectedOverlayDisableClose]="true" + [cdkConnectedOverlayOrigin]="searchInput" + [cdkConnectedOverlayOpen]="searching() || searchingResultsVisible()" + [cdkConnectedOverlayPositions]="positions" + [cdkConnectedOverlayHasBackdrop]="true" + [cdkConnectedOverlayBackdropClass]="'cdk-overlay-transparent-backdrop'" + (overlayOutsideClick)="backdropClicked($event)"> + <div class="search-results w-96 border p-2 text-base max-h-96 overflow-y-auto"> + @if (searching()) { + <div class="unset neutral-color italic" role="status">Searching</div> + } @else { + @if (hasResults()) { + <ul role="listbox" aria-label="Search results"> + @if (results().processorResults.length > 0) { + <ng-container + *ngTemplateOutlet=" + renderResults; + context: { + $implicit: results().processorResults, + header: 'Processors', + icon: 'icon-processor', + path: ComponentType.Processor + } + "></ng-container> + } + @if (results().connectionResults.length > 0) { + <ng-container + *ngTemplateOutlet=" + renderResults; + context: { + $implicit: results().connectionResults, + header: 'Connections', + icon: 'icon-connect', + path: ComponentType.Connection + } + "></ng-container> + } + @if (results().processGroupResults.length > 0) { + <ng-container + *ngTemplateOutlet=" + renderResults; + context: { + $implicit: results().processGroupResults, + header: 'Process groups', + icon: 'icon-group', + path: ComponentType.ProcessGroup + } + "></ng-container> + } + @if (results().remoteProcessGroupResults.length > 0) { + <ng-container + *ngTemplateOutlet=" + renderResults; + context: { + $implicit: results().remoteProcessGroupResults, + header: 'Remote process groups', + icon: 'icon-group-remote', + path: ComponentType.RemoteProcessGroup + } + "></ng-container> + } + @if (results().inputPortResults.length > 0) { + <ng-container + *ngTemplateOutlet=" + renderResults; + context: { + $implicit: results().inputPortResults, + header: 'Input ports', + icon: 'icon-port-in', + path: ComponentType.InputPort + } + "></ng-container> + } + @if (results().outputPortResults.length > 0) { + <ng-container + *ngTemplateOutlet=" + renderResults; + context: { + $implicit: results().outputPortResults, + header: 'Output ports', + icon: 'icon-port-out', + path: ComponentType.OutputPort + } + "></ng-container> + } + @if (results().funnelResults.length > 0) { + <ng-container + *ngTemplateOutlet=" + renderResults; + context: { + $implicit: results().funnelResults, + header: 'Funnels', + icon: 'icon-funnel', + path: ComponentType.Funnel + } + "></ng-container> + } + @if (results().labelResults.length > 0) { + <ng-container + *ngTemplateOutlet=" + renderResults; + context: { + $implicit: results().labelResults, + header: 'Labels', + icon: 'icon-label', + path: ComponentType.Label + } + "></ng-container> + } + @if (results().controllerServiceNodeResults.length > 0) { + <ng-container + *ngTemplateOutlet=" + renderResults; + context: { + $implicit: results().controllerServiceNodeResults, + header: 'Controller services', Review Comment: The casing is different here (sentence case) vs in flow designer where it uses title case. this applies to the other multi-word header groupings here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
