fgerlits commented on code in PR #2157:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2157#discussion_r3099162516
##########
minifi-api/include/minifi-cpp/core/ProcessContext.h:
##########
@@ -91,8 +91,13 @@ class ProcessContext : public virtual
core::VariableRegistry, public virtual uti
virtual std::shared_ptr<core::controller::ControllerServiceHandle>
getControllerService(const std::string &identifier, const utils::Identifier
&processor_uuid) const = 0;
static constexpr char const* DefaultStateStorageName = "defaultstatestorage";
+ // Locally creates a StateManager instance, commiting or rolling back
changes to the component state is the responsibility of the caller.
+ virtual std::unique_ptr<StateManager> createStateManager() = 0;
+
+ // Returns the StateManager associated with the current ProcessSession, the
lifetime of which is scoped to a single execution of a Processor's onTrigger
method.
+ // The ProcessSession is responsible for commiting or rolling back any
changes to the component state at the end of the onTrigger execution.
Review Comment:
thanks for adding the comments, and sorry for the nitpicking, but
```suggestion
// Locally creates a StateManager instance, committing or rolling back
changes to the component state is the responsibility of the caller.
virtual std::unique_ptr<StateManager> createStateManager() = 0;
// Returns the StateManager associated with the current ProcessSession,
the lifetime of which is scoped to a single execution of a Processor's
onTrigger method.
// The ProcessSession is responsible for committing or rolling back any
changes to the component state at the end of the onTrigger execution.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
