exceptionfactory commented on code in PR #11124:
URL: https://github.com/apache/nifi/pull/11124#discussion_r3112994920
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java:
##########
@@ -123,6 +132,7 @@ public class TransformXml extends AbstractProcessor {
.required(false)
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
+ .identifiesExternalResource(ResourceCardinality.SINGLE,
ResourceType.TEXT)
Review Comment:
Thanks for noting the reason. With that in mind, it looks like that ternary
needs to be refactored to avoid calling `asResource()` on the Controller Key
property. That property should be a standard string, not a Resource Reference.
Taking it one step further
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java:
##########
@@ -123,6 +132,7 @@ public class TransformXml extends AbstractProcessor {
.required(false)
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
+ .identifiesExternalResource(ResourceCardinality.SINGLE,
ResourceType.TEXT)
Review Comment:
Thanks for noting the reason. With that in mind, it looks like that ternary
needs to be refactored to avoid calling `asResource()` on the Controller Key
property. That property should be a standard string, not a Resource Reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
