markap14 commented on code in PR #11166:
URL: https://github.com/apache/nifi/pull/11166#discussion_r3117597642
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/util/FlowDifferenceFilters.java:
##########
@@ -992,7 +997,16 @@ private static boolean isPropertyAddedFromMigration(final
FlowDifference differe
componentNode = null;
}
- return isNotDynamicProperty(fieldName.get(), componentNode);
+ if (!isNotDynamicProperty(fieldName.get(), componentNode)) {
Review Comment:
It looks like this is the only place we're using this method. Can we rename
to `isDynamicProperty` and invert it? I don't like negations in method names
but we definitely shouldn't be negating the result of a method called
`isNotDynamicProperty`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
