markap14 commented on code in PR #11164:
URL: https://github.com/apache/nifi/pull/11164#discussion_r3131457521
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java:
##########
@@ -2133,13 +2132,14 @@ public int getMaxTimerDrivenThreadCount() {
}
public int getActiveTimerDrivenThreadCount() {
- return timerDrivenEngineRef.get().getActiveCount();
+ return timerDrivenEngineRef.get().getActiveCount() +
virtualThreadSchedulingAgent.getActiveThreadCount();
}
public void setMaxTimerDrivenThreadCount(final int maxThreadCount) {
writeLock.lock();
try {
setMaxThreadCount(maxThreadCount, "Timer Driven",
this.timerDrivenEngineRef.get(), this.maxTimerDrivenThreads);
+ virtualThreadSchedulingAgent.setMaxThreadCount(maxThreadCount);
Review Comment:
Yeah, I had this fixed locally but forgot to push the commit. Now, the
timer-driven engine is used only for framework tasks, so I renamed it and just
hardcoded it to 8 threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]