Copilot commented on code in PR #2166: URL: https://github.com/apache/nifi-minifi-cpp/pull/2166#discussion_r3159726147
########## minifi-api/minifi-c-api.def: ########## @@ -16,12 +16,17 @@ EXPORTS MinifiProcessSessionCreate MinifiProcessSessionTransfer MinifiProcessSessionRemove + MinifiProcessSessionPenalize MinifiProcessSessionRead MinifiProcessSessionWrite MinifiConfigGet MinifiInputStreamSize MinifiInputStreamRead MinifiOutputStreamWrite - MinifiFlowFileSetAttribute - MinifiFlowFileGetAttribute - MinifiFlowFileGetAttributes + MinifiProcessSessionSetFlowFileAttribute + MinifiProcessSessionGetFlowFileAttribute + MinifiProcessSessionGetFlowFileAttributes + MinifiProcessSessionGetFlowFileSize + MinifiProcessSessionGetFlowFileId + MinifiProcessContextGetDynamicProperties + MinifiProcessContextGetSslData Review Comment: This .def export list removes the previously exported `MinifiFlowFileSetAttribute/GetAttribute/GetAttributes` symbols and replaces them with new `MinifiProcessSession*` names. On Windows this is an ABI-breaking change for any existing extension DLLs linking against the old symbol names. Consider keeping the old exports as backward-compatible wrappers/aliases (at least for one major API version), or bumping the API/ABI appropriately and documenting the breaking change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
