lordgamez commented on code in PR #2112:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2112#discussion_r3168782247
##########
extensions/gcp/processors/GCSProcessor.cpp:
##########
@@ -48,13 +48,46 @@ void GCSProcessor::onSchedule(core::ProcessContext&
context, core::ProcessSessio
endpoint_url_ = context.getProperty(EndpointOverrideURL) |
utils::toOptional();
if (endpoint_url_)
logger_->log_debug("Endpoint overwritten: {}", *endpoint_url_);
+
+ auto proxy_controller_service =
minifi::utils::parseOptionalControllerService<minifi::controllers::ProxyConfigurationServiceInterface>(context,
ProxyConfigurationService, getUUID());
+ if (proxy_controller_service) {
+ if (proxy_controller_service->getProxyType() ==
minifi::controllers::ProxyType::DIRECT) {
+ logger_->log_debug("Proxy configuration service indicates DIRECT
connection, no proxy will be used for GCS processor");
+ return;
+ }
Review Comment:
Updated in
https://github.com/apache/nifi-minifi-cpp/pull/2112/commits/5eae350c864470a83956c83fd6c6d04cac8207ad
##########
extensions/gcp/processors/GCSProcessor.cpp:
##########
@@ -48,13 +48,42 @@ void GCSProcessor::onSchedule(core::ProcessContext&
context, core::ProcessSessio
endpoint_url_ = context.getProperty(EndpointOverrideURL) |
utils::toOptional();
if (endpoint_url_)
logger_->log_debug("Endpoint overwritten: {}", *endpoint_url_);
+
+ auto proxy_controller_service =
minifi::utils::parseOptionalControllerService<minifi::controllers::ProxyConfigurationServiceInterface>(context,
ProxyConfigurationService, getUUID());
+ if (proxy_controller_service) {
+ if (proxy_controller_service->getProxyType() ==
minifi::controllers::ProxyType::DIRECT) {
+ logger_->log_debug("Proxy configuration service indicates DIRECT
connection, no proxy will be used for GCS processor");
+ return;
+ }
+
+ logger_->log_debug("Proxy configuration is set for GCS processor");
+
+ proxy_ = google::cloud::ProxyConfig{};
+
proxy_->set_scheme(minifi::utils::string::startsWith(proxy_controller_service->getHost(),
"https") ? "https" : "http");
+ auto proxy_host = proxy_controller_service->getHost();
+ if (minifi::utils::string::startsWith(proxy_host, "https://";)) {
+ proxy_host = proxy_host.substr(8);
+ } else if (minifi::utils::string::startsWith(proxy_host, "http://";)) {
+ proxy_host = proxy_host.substr(7);
Review Comment:
Updated in
https://github.com/apache/nifi-minifi-cpp/pull/2112/commits/5eae350c864470a83956c83fd6c6d04cac8207ad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
