szaszm commented on code in PR #2163:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2163#discussion_r3181399256
##########
libminifi/src/FlowController.cpp:
##########
@@ -130,6 +131,10 @@ std::expected<void, std::string>
FlowController::applyConfiguration(const std::s
std::lock_guard<std::recursive_mutex> flow_lock(mutex_);
stop();
+ // Clear the controller services now that all timer callback threads have
been stopped
+ clearControllerServices();
+ controller_service_provider_impl_ =
flow_configuration_->getControllerServiceProvider();
+
Review Comment:
where did this happen before the change?
##########
libminifi/src/core/ProcessGroup.cpp:
##########
@@ -169,15 +172,18 @@ void
ProcessGroup::startProcessingProcessors(TimerDrivenSchedulingAgent& timeSch
// The admin yield duration comes from the configuration, should be equal in
all three schedulers
std::chrono::milliseconds admin_yield_duration =
timeScheduler.getAdminYieldDuration();
- if (!onScheduleTimer_ && !failed_processors.empty() && admin_yield_duration
> 0ms) {
- logger_->log_info("Retrying failed processors in {}",
admin_yield_duration);
Review Comment:
Is there a reason to remove this log message? If not, I'd keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
