Copilot commented on code in PR #2169: URL: https://github.com/apache/nifi-minifi-cpp/pull/2169#discussion_r3194483400
########## extensions/splunk/tests/features/environment.py: ########## @@ -14,11 +14,17 @@ # limitations under the License. import platform +import docker +from containers.splunk_container import SplunkContainer from minifi_behave.core.hooks import common_before_scenario from minifi_behave.core.hooks import common_after_scenario +def before_all(context): + docker.from_env().images.pull(SplunkContainer.IMAGE) + Review Comment: `before_all` pulls the Splunk image unconditionally, but this test suite already skips `x86_x64_only` features in `before_feature`. On non-x86 platforms this will still attempt to pull an image that may be unavailable/incompatible and can fail the run before the skip happens. Consider moving the pull into `before_feature` (after the architecture check) or guarding the pull with the same `is_x86` condition / feature tag check so skipped features don’t trigger image pulls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
