rfellows commented on code in PR #11193:
URL: https://github.com/apache/nifi/pull/11193#discussion_r3195279259
##########
nifi-frontend/src/main/frontend/libs/shared/src/components/connector-property-input/connector-property-input.component.html:
##########
@@ -26,7 +26,44 @@
</mat-checkbox>
}
@default {
- @if (shouldUseSelect()) {
+ @if (shouldUseAssetUpload()) {
+ <div class="w-full flex flex-col gap-1"
data-qa="property-input-asset-upload-block">
+ <div class="text-xs tertiary-color">
+ {{ prop.name }}
+ @if (prop.required) {
+ <span aria-hidden="true"> *</span>
+ }
+ </div>
+ <asset-upload
+ [formControl]="formControl"
+ [assets]="currentAssets()"
+ [uploadProgress]="assetUploadProgress()"
+ [multiple]="isMultipleAssets()"
+ (filesSelected)="onAssetFilesSelected($event)"
+ (deleteAsset)="onAssetDeleteRequested($event)"
+ (dismissFailedUpload)="onDismissFailedUpload($event)"
+ data-qa="property-input-asset-upload">
+ </asset-upload>
+ @if (prop.description && (!parentControl?.invalid ||
!parentControl?.touched)) {
+ <mat-hint class="text-xs">{{ prop.description
}}</mat-hint>
Review Comment:
It does not. Both <mat-error> and `<mat-hint>` here are used outside a
`<mat-form-field>` and without the color and size classes, they look like body
text.
This is what each look like with the css classes removed...
<img width="848" height="627" alt="Screenshot 2026-05-06 at 08 08 41"
src="https://github.com/user-attachments/assets/94bea513-0673-4caf-bfdd-9bf4da2860cd";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
