awelless commented on code in PR #11221:
URL: https://github.com/apache/nifi/pull/11221#discussion_r3207828992
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/repository/StandardProcessSessionIT.java:
##########
@@ -1601,7 +1601,10 @@ public void
testMissingFlowFileExceptionThrownWhenUnableToReadData() {
// attempt to read the data.
final FlowFile ff1 = session.get();
- assertThrows(MissingFlowFileException.class, () -> session.read(ff1,
InputStream::read));
+ final MissingFlowFileException ex =
assertThrows(MissingFlowFileException.class,
+ () -> session.read(ff1, InputStream::read));
+
assertTrue(ex.getMessage().contains("12345678-1234-1234-1234-123456789012"));
+ assertTrue(ex.getMessage().contains("rolling back"));
Review Comment:
In general asserting exception messages is a questionable practice. But
since this change is focusing on the messages in particular, I wanted to ensure
the change is covered.
Let me know if you see it redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
