ing-mattioni commented on PR #11191: URL: https://github.com/apache/nifi/pull/11191#issuecomment-4439388357
> Thanks for the contribution @ing-mattioni. The change looks straightforward. Have you evaluated options for testing this change in behavior? If you can rebase the pull request to the latest `main` branch, that would be helpful. Thanks for the review @exceptionfactory. Yes, I agree that adding targeted tests would make the behavioral change clearer. I am going to look into adding coverage for the manual acknowledgement path, specifically: - successful `ProcessSession` commit should call `basicAck(lastDeliveryTag, true)` - failed `ProcessSession` commit should call `basicNack(lastDeliveryTag, true, true)` - auto-acknowledge mode should not issue manual ack/nack calls I will also rebase the branch against the latest `main`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
