turcsanyip commented on PR #11213: URL: https://github.com/apache/nifi/pull/11213#issuecomment-4502470437
@rakesh-rsky I checked the latest changes and the error handling is correct now functionally. However, the synchronous wait led to significant performance degradation compared to the original version. According to my measurement: - local NiFi + local RabbitMQ in Docker: 10x slower - local NiFi + RabbitMQ on a cloud VM: 300-1000x slower (depending on the cloud location) So even if the error handling is improved, I don't think we can add the change as-is due to the performance effect. I suggest adding a feature flag property (e.g. `Use Message Confirmation` = true / false or Delivery Guarantee = At least once / At most once) with proper documentation on the pros and cons. This way, the user can optionally enable this feature if they want the extra failure handling, at the cost of performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
