ing-mattioni commented on code in PR #11242:
URL: https://github.com/apache/nifi/pull/11242#discussion_r3280185023
##########
nifi-extension-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java:
##########
@@ -95,6 +97,14 @@ public class PublishAMQP extends
AbstractAMQPProcessor<AMQPPublisher> {
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
+ public static final PropertyDescriptor MAX_OUTBOUND_MESSAGE_BODY_SIZE =
new PropertyDescriptor.Builder()
+ .name("Max Outbound Message Body Size")
+ .description("Maximum body size of outbound messages. FlowFiles
larger than this value are routed to failure without loading content into
memory.")
+ .required(true)
+ .defaultValue("64 MB")
Review Comment:
Good point. I updated the change to avoid treating 64 MB as a general AMQP
maximum.
RabbitMQ documents `max_message_size` as configurable, with a current
documented default of 128 MiB and a maximum allowed value of 512 MiB. I changed
the property to use a 128 MB default and described it as a NiFi-side defensive
memory guard rather than a protocol-level AMQP limit. The property description
now recommends configuring the value according to broker limits and available
JVM memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
