lordgamez commented on code in PR #2174: URL: https://github.com/apache/nifi-minifi-cpp/pull/2174#discussion_r3282821408
########## CMakeLists.txt: ########## @@ -301,8 +300,12 @@ target_compile_definitions(RapidJSON INTERFACE RAPIDJSON_HAS_STDSTRING) include(GslLite) # Add necessary definitions based on the value of STRICT_GSL_CHECKS, see gsl-lite README for more details -list(APPEND GslDefinitions gsl_CONFIG_DEFAULTS_VERSION=1) Review Comment: I removed it becuase that's the default, but we can keep it to be explicit if you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
