martinzink commented on code in PR #2176:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2176#discussion_r3322328028
##########
core-framework/include/core/controller/ControllerServiceFactoryImpl.h:
##########
@@ -34,13 +34,13 @@ class ControllerServiceFactoryImpl : public
ControllerServiceFactory {
: class_name_(core::className<T>()) {
}
- explicit ControllerServiceFactoryImpl(std::string group_name)
- : group_name_(std::move(group_name)),
+ explicit ControllerServiceFactoryImpl(std::string module_name)
Review Comment:
Ive renamed it from group_name to module_name, because this groupname was
not the groupname in C2 but rather the artifact name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
