Copilot commented on code in PR #2192:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2192#discussion_r3342284168
##########
minifi-api/include/minifi-cpp/controllers/AttributeProviderService.h:
##########
@@ -22,14 +22,22 @@
#include <vector>
#include "minifi-cpp/core/controller/ControllerServiceHandle.h"
+#include "minifi-cpp/core/ControllerServiceTypeDefinition.h"
Review Comment:
AttributeProviderService::ProvidesApi uses MINIFI_VERSION_STR, but this
header does not include the header that defines it. This makes the header
non-self-contained and can fail to compile depending on include order.
##########
extensions/kubernetes/controllerservice/KubernetesControllerService.h:
##########
@@ -57,6 +57,8 @@ class KubernetesControllerService : public
AttributeProviderServiceImpl {
EXTENSIONAPI static constexpr bool SupportsDynamicProperties = false;
ADD_COMMON_VIRTUAL_FUNCTIONS_FOR_CONTROLLER_SERVICES
+ static constexpr auto ImplementsApis = std::array{
AttributeProviderService::ProvidesApi };
Review Comment:
For extension controller services, metadata fields like ImplementsApis are
typically marked with EXTENSIONAPI (same as Description/Properties) so they
have consistent visibility on Windows builds. KubernetesControllerService adds
ImplementsApis without EXTENSIONAPI, which is inconsistent with other
controller services (e.g., JsonTreeReader).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
