[ https://issues.apache.org/jira/browse/NIFI-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869178#comment-15869178 ]
ASF GitHub Bot commented on NIFI-3354: -------------------------------------- Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/1436 This is really cool and I suspect these processors will get a lot of use. Some feedback below. TransformCSVtoJSON: 1) It needs to set the content type attribute. Aids content viewing and routing decisions. For example flowFile = session.putAttribute(flowFile, CoreAttributes.MIME_TYPE.key(), "application/json"); UpdateAttributeWithSchema: 1) Recommend changing the name to 'ExtractSchema'. The name is confusing when you consider 'UpdateAttribute' processor and what that one does (and is very common). 2) It grabs the schema definition from the registry service and makes that a flow file attribute. This is problematic if the schema is large. We do not want large flow file attributes. So this needs to be limited. Why is this processor needed? TransformJSONToAvro: 1) Needs to set the content type attribute. According to the latest avro spec it is "avro/binary" TransformAvroToCSV 1) Needs to set the content type attribute. "text/csv" TransformCSVToAvro 1) Needs to set the content type attribute. TransformAvroToJson 1) Needs to set the content type attribute. TransformJSONToCSV 1) Needs to set the content type attribute. > Create CSV To Avro transformer > ------------------------------ > > Key: NIFI-3354 > URL: https://issues.apache.org/jira/browse/NIFI-3354 > Project: Apache NiFi > Issue Type: Sub-task > Reporter: Oleg Zhurakousky > Assignee: Oleg Zhurakousky > Fix For: 1.2.0 > > Attachments: csv_content.txt, NIFI-3354.xml > > > While we currently have CSV to AVRO transformer it required HDFS/Kite > dependencies which could be easily eliminated. -- This message was sent by Atlassian JIRA (v6.3.15#6346)