markap14 commented on code in PR #11320:
URL: https://github.com/apache/nifi/pull/11320#discussion_r3381132105
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-kinesis/src/main/java/org/apache/nifi/processors/aws/kinesis/LegacyCheckpointMigrator.java:
##########
@@ -77,13 +77,20 @@ String findMigrationTable() {
return null;
}
- void cleanupLingeringMigration() {
+ void completeLingeringMigration() {
final String lingeringMigration = findMigrationTable();
if (lingeringMigration == null) {
return;
}
- logger.info("Deleting orphaned migration table [{}]; legacy checkpoint
table [{}] retains original data", lingeringMigration, checkpointTableName);
- CheckpointTableUtils.deleteTable(dynamoDbClient, logger,
lingeringMigration);
+ logger.warn("Checkpoint table [{}] is in place but migration table
[{}] still exists from a prior rename; not all checkpoints may have been
migrated, re-copying before deletion",
Review Comment:
No need to warn here, an info level message should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
