szaszm commented on code in PR #2200:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2200#discussion_r3404513998
##########
cmake/ZLIB.cmake:
##########
@@ -29,6 +29,14 @@ FetchContent_Declare(
FetchContent_MakeAvailable(zlib)
+if(CMAKE_BUILD_TYPE STREQUAL "Debug")
+ if(WIN32)
+ set(_zlib_debug_suffix "d")
+ else()
+ set(_zlib_debug_suffix "")
+ endif()
+endif()
Review Comment:
what do you think about this version?
```suggestion
if(WIN32 AND CMAKE_BUILD_TYPE STREQUAL "Debug")
set(_zlib_debug_suffix "d")
else()
set(_zlib_debug_suffix "")
endif()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
