pvillard31 opened a new pull request, #11336:
URL: https://github.com/apache/nifi/pull/11336
# Summary
NIFI-16020 Consume request body before two-phase cluster replication
responses to prevent HTTP/2 stream resets
Several REST resource methods do not declare a request entity parameter (for
example `POST /flowfile-queues/{id}/drop-requests`), so the JAX-RS layer never
reads the request body even though the replicating node always sends one. When
a node returns the two-phase commit validation, execution, or cancellation
response without consuming that body, Jetty 12.1.10 resets the HTTP/2 stream
with `CANCEL`, which surfaces on the replicating node as "RST_STREAM received
Stream cancelled" and fails the replicated request (which cannot be retried).
`ApplicationResource.withWriteLock` now fully consumes the request input
stream for two-phase requests before any early response is returned, allowing
the replicating node to complete its upload cleanly. When the body has already
been consumed (for example via entity deserialization) the drain is a no-op.
This server-side fix replaces the temporary HTTP/1.1 cluster workaround
added in NIFI-16011, so the configurable
`nifi.cluster.node.protocol.http.version` property introduced there and the
HTTP_1_1 overrides in the system-test configurations are reverted.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue
created
### Pull Request Tracking
- Pull Request title starts with Apache NiFi Jira issue number, such as
`NIFI-00000`
- Pull Request commit message starts with Apache NiFi Jira issue number, as
such `NIFI-00000`
- Pull request contains [commits
signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
with a registered key indicating `Verified` status
### Pull Request Formatting
- Pull Request based on current revision of the `main` branch
- Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request
creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License
Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE`
files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
