lordgamez commented on code in PR #2201: URL: https://github.com/apache/nifi-minifi-cpp/pull/2201#discussion_r3474940114
########## thirdparty/lmdb/add-cmake-file.patch: ########## @@ -0,0 +1,29 @@ +lmdb only comes with a Makefile which only works on Linux so we create our own CMakeLists.txt file to be platform independent + +diff -rupN orig/libraries/liblmdb/CMakeLists.txt patched/libraries/liblmdb/CMakeLists.txt +--- orig/libraries/liblmdb/CMakeLists.txt 2026-06-12 13:02:00.868592927 +0200 ++++ patched/libraries/liblmdb/CMakeLists.txt 2026-06-12 11:51:51.369241534 +0200 +@@ -0,0 +1,23 @@ ++cmake_minimum_required(VERSION 3.25) ++project(lmdb C) ++ ++if(MSVC) ++ add_compile_options(/W3 /WX-) ++else() ++ add_compile_options(-W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -O2 -g) Review Comment: Good point, these options were only mirrored from the original Makefile of the project but should not be necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
