exceptionfactory commented on code in PR #95:
URL: https://github.com/apache/nifi-api/pull/95#discussion_r3536872358
##########
pom.xml:
##########
@@ -178,6 +178,36 @@
</plugins>
</pluginManagement>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>copy-mockito-agent</id>
Review Comment:
```suggestion
<id>copy-mockito-core</id>
```
##########
pom.xml:
##########
@@ -178,6 +178,36 @@
</plugins>
</pluginManagement>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
Review Comment:
I recommend adding a comment for this execution indicating it is necessary
to avoid warnings, along these lines:
```suggestion
<!-- Copy mockito-core library to target directory to
avoid warnings in IntelliJ for agent loading -->
<execution>
```
##########
pom.xml:
##########
@@ -178,6 +178,36 @@
</plugins>
</pluginManagement>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>copy-mockito-agent</id>
+ <phase>initialize</phase>
+ <goals>
+ <goal>copy</goal>
+ </goals>
+ <configuration>
+ <artifactItems>
+ <artifactItem>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-core</artifactId>
+
<outputDirectory>${project.build.directory}/agents</outputDirectory>
+
<destFileName>mockito-core.jar</destFileName>
+ </artifactItem>
+ </artifactItems>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+
<argLine>-javaagent:${settings.localRepository}/org/mockito/mockito-core/${mockito.version}/mockito-core-${mockito.version}.jar</argLine>
Review Comment:
```suggestion
<!-- Configure mockito-core as Java Agent to enable
explicit attachment to processes -->
<argLine>-javaagent:${settings.localRepository}/org/mockito/mockito-core/${mockito.version}/mockito-core-${mockito.version}.jar</argLine>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
