kevdoran opened a new pull request, #11407:
URL: https://github.com/apache/nifi/pull/11407

   # Summary
   
   Relates to [NIFI-16088](https://issues.apache.org/jira/browse/NIFI-16088).
   
   Cron triggers are scheduled as one-shot tasks that reschedule only after a 
successful run (`CronSchedulingAgent`). If the triggered task throws, or 
scheduling the next trigger fails, the scheduling chain silently terminates: 
the component stays `RUNNING` but never fires again on its schedule until it is 
stopped and started — with nothing in the logs, because the exception is 
discarded by the scheduled executor.
   
   This adds **diagnostics only** (no scheduling or lifecycle behavior is 
changed):
   
   - `CronSchedulingAgent`: log a WARN (before propagating) when a 
cron-scheduled trigger throws, or when rescheduling the next trigger fails, 
noting the component will not run again on its schedule until it is stopped and 
started.
   - `ConnectableTask`: log at INFO (was DEBUG) when a cron-driven, 
Primary-Node-Only component's fire is skipped because the node is not the 
primary node; timer-driven components stay at DEBUG to avoid noise, since cron 
fires are comparatively rare.
   
   Motivated by a case where Primary-Node-Only cron processors silently stopped 
firing after a heartbeat-induced disconnect/reconnect and had to be manually 
stopped/started; the existing logs gave no signal as to why.
   
   # Verification
   
   - New unit test in `CronSchedulingAgentTest` asserting a triggered exception 
still propagates (is not silently swallowed).
   - `./mvnw -pl nifi-framework-bundle/nifi-framework/nifi-framework-core -am 
test -Dtest=CronSchedulingAgentTest` — green (4 tests).
   - `checkstyle:check` clean for the module.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to